Skip to content

Add YouTube Music to supported links#3074

Closed
gkeegan wants to merge 1 commit intoTeamNewPipe:devfrom
gkeegan:youtube-music
Closed

Add YouTube Music to supported links#3074
gkeegan wants to merge 1 commit intoTeamNewPipe:devfrom
gkeegan:youtube-music

Conversation

@gkeegan
Copy link
Contributor

@gkeegan gkeegan commented Feb 11, 2020 •
edited
Loading

This works when sharing songs from the YouTube Music app. From the web browser interface for YouTube Music, opening the link in NewPipe app causes a playlist to open that contains the song. This isn't ideal and will require some extractor changes that I will do later, if I can figure it out.

I chose to put the URL into the intent I chose because the one with youtu.be causes a worse result from the web interface. It caused an error instead of just opening as a playlist.

I understand if this is chosen not to be merged until I get the extractor end working.

Debug APK: ytmusic.zip

@gkeegan
Add YouTube Music to supported links
4483e4b 
This works for sharing songs from the YouTube Music app. From the web interface for YouTube Music, opening the link in NewPipe app causes a playlist to open that contains the song. This isn't ideal and will require some extractor changes that I will do later, if I can figure it out.
@gkeegan gkeegan mentioned this pull request Feb 11, 2020
Closed
@XiangRongLin
Copy link
Collaborator

XiangRongLin commented Feb 11, 2020 •
edited
Loading

It crashes for me when i click on the "open in app" icon on Firefox.
Edit: I opened a single video and then clicked on that.

The seems like YouTube music is always playing a mix, which newpipe can't extract yet.
I'm working on that in TeamNewPipe/NewPipeExtractor#253

Exception

Crash log

org.schabi.newpipe.extractor.exceptions.ParsingException: Could not get playlist name
	at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubePlaylistExtractor.getName(YoutubePlaylistExtractor.java:55)
	at org.schabi.newpipe.extractor.playlist.PlaylistInfo.getInfo(PlaylistInfo.java:49)
	at org.schabi.newpipe.extractor.playlist.PlaylistInfo.getInfo(PlaylistInfo.java:30)
	at org.schabi.newpipe.util.ExtractorHelper.lambda$getPlaylistInfo$8(ExtractorHelper.java:155)
	at org.schabi.newpipe.util.-$$Lambda$ExtractorHelper$oXX6037sP0Rn784EpEbKFh6xH48.call(Unknown Source:4)
	at io.reactivex.internal.operators.single.SingleFromCallable.subscribeActual(SingleFromCallable.java:44)
	at io.reactivex.Single.subscribe(Single.java:3438)
	at io.reactivex.internal.operators.single.SingleDoOnSuccess.subscribeActual(SingleDoOnSuccess.java:35)
	at io.reactivex.Single.subscribe(Single.java:3438)
	at io.reactivex.internal.operators.maybe.MaybeFromSingle.subscribeActual(MaybeFromSingle.java:41)
	at io.reactivex.Maybe.subscribe(Maybe.java:4154)
	at io.reactivex.internal.operators.maybe.MaybeConcatArray$ConcatMaybeObserver.drain(MaybeConcatArray.java:153)
	at io.reactivex.internal.operators.maybe.MaybeConcatArray$ConcatMaybeObserver.request(MaybeConcatArray.java:78)
	at io.reactivex.internal.operators.flowable.FlowableElementAtMaybe$ElementAtSubscriber.onSubscribe(FlowableElementAtMaybe.java:66)
	at io.reactivex.internal.operators.maybe.MaybeConcatArray.subscribeActual(MaybeConcatArray.java:42)
	at io.reactivex.Flowable.subscribe(Flowable.java:14479)
	at io.reactivex.internal.operators.flowable.FlowableElementAtMaybe.subscribeActual(FlowableElementAtMaybe.java:36)
	at io.reactivex.Maybe.subscribe(Maybe.java:4154)
	at io.reactivex.internal.operators.maybe.MaybeToSingle.subscribeActual(MaybeToSingle.java:46)
	at io.reactivex.Single.subscribe(Single.java:3438)
	at io.reactivex.internal.operators.single.SingleSubscribeOn$SubscribeOnObserver.run(SingleSubscribeOn.java:89)
	at io.reactivex.Scheduler$DisposeTask.run(Scheduler.java:578)
	at io.reactivex.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:66)
	at io.reactivex.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:57)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:301)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
	at java.lang.Thread.run(Thread.java:919)
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String org.jsoup.nodes.Element.text()' on a null object reference
	at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubePlaylistExtractor.getName(YoutubePlaylistExtractor.java:53)
	... 28 more

@Stypox Stypox linked an issue Feb 11, 2020 that may be closed by this pull request
Youtube Music link support #3073
Closed
@gkeegan
Copy link
Contributor Author

gkeegan commented Feb 11, 2020

That's the error I got when putting the link by youtu.be. I may have uploaded the wrong apk, because the one I'm using can open that link fine.

@gkeegan gkeegan closed this Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Youtube Music link support

2 participants

@gkeegan @XiangRongLin

Comments